Fix #2120, Support clang for whole archive flags #2204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
W/ Clang 10 installed, performed the following changes in sample_defs:
Expected behavior changes
Properly sets the whole archive flags for clang, warns if compiler is unmatched
System(s) tested on
CI shows no impact to base system
Steps above to prove Clang works
Additional context
Could add to CI if someone wanted to maintain support, might be overcome if there's a target added to CI that uses clang.
Clang build does depend on nasa/sample_lib#92 being merged, but doesn't impact current CI
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC